Bug #129

Some papercut bugs

Added by Brice Maron over 2 years ago. Updated about 1 month ago.

Status:Closed Start:26/10/2009
Priority:Normal Due date:
Assigned to:Clément OUDOT % Done:

100%
Category:Self Service Password
Target version:self-service-password-0.3 Estimated time:0.50 hour

Description

Hi... i've try to use your password Self Service but there where some bugs...

I've try to make a patch for some of them...
For now i can test more because i don't have a ldap right here...

So there is :
  • Adding a debug param in config ( it may be an idea to remove aaaall @ in front of ldap function)
  • Adding an error reporing to All when debug is on
  • Initiate variable of login,...
  • Test if a key is set with function isset
  • Change $_POST & $_GET to ==> $_REQUEST ...(this may be remove if you really don't want to include $_COOKIES)
  • Remove the ?> at end of file... it prevent errors :)
  • Adding an error if Php ldap is not here...
  • Changing error testing..

it's a good start...

some_papercut.patch - A patch for these issues (3.4 KB) Brice Maron, 26/10/2009 21:31

some_papercut.patch - A patch for these issues (3.7 KB) Brice Maron, 26/10/2009 21:34

Associated revisions

Revision 39
Added by Jonathan Clarke over 2 years ago

Fix typo in translation (fr/en). Refs #129.

History

Updated by Brice Maron over 2 years ago

Oups bad version of the patch

Updated by Clément OUDOT over 2 years ago

  • Status changed from New to Assigned
  • Assigned to set to Clément OUDOT
  • Target version changed from self-service-password-0.2 to self-service-password-0.3

Thanks for the patch. I will work on it as soon as possible.

Updated by Clément OUDOT over 2 years ago

Brice,

some questions on your patch:
  • the php-ldap check is commented, why?
  • Are sure of the triple equal sign in the $result check ($result === "")
  • You remove the @ of the ldap_connect function, is it for the debug functionality?

Thanks for your help,

Clément.

Updated by Brice Maron over 2 years ago

Oups :)

  • php-ldap test commented is an error :p it should be uncommented...
  • the triple equal is not necessary here.. but it's a good practice to use identical operator instead of just the equal one.
  • yes i remove the for debug purpose... i could be reset ... but i think that we should remove all in the code to replace them by the error_reporting statement (E_ALL in debug and 0 in production...)

Sorry the patch was done too quickly :/

Updated by Clément OUDOT over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Patch applied in r38.

Thanks for comments and help.

Also available in: Atom PDF